> Add some comments to this file to explain what the native code is doing?ĭone, there's still a room for improvement, I think. > +nsMacShellService::OnStateChange(nsIWebProgress* aWebProgress, This was left from Ben's patch, but as pIndex isn't declared even, I've removed it. Well, they're built separatley, so i'm not sure we can fix it easily. > Why is the "DEFINES += -DHAVE_SHELL_SERVICE=1" code in two places? Would be > Please try to keep the lines under 80 chars wide. Please add some comments about which ones need |CFRetain| and |CFRelease|. +// its best to leave them here since they are not documented anywhere else +// these functions are undocumented - even if we're not using them all |mBackgroundPosition|, but it is never actually used. In |SetDesktopBackground()|, the param |aPosition| is saved to Will you get to this later, or worry about it in a different bug? +nsMacShellService::GetDesktopBackgroundColor(PRUint32 *aColor) You can replace these with a call to |NS_NewNativeLocalFile()|. + lf->InitWithNativePath(DESKTOP_PREFPANE) +nsMacShellService::OnStateChange(nsIWebProgress* aWebProgress,Īdd some comments to this file to explain what the native code is doing? Why is the "DEFINES += -DHAVE_SHELL_SERVICE=1" code in two places? Would be Please try to keep the lines under 80 chars wide.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |